-
Notifications
You must be signed in to change notification settings - Fork 560
Support stylus contracts publish and deploy #6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d90dda7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
packages/thirdweb/src/cli/commands/publish-stylus/publish-stylus.ts
Outdated
Show resolved
Hide resolved
packages/thirdweb/src/cli/commands/publish-stylus/publish-stylus.ts
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (30.92%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6495 +/- ##
==========================================
- Coverage 55.07% 54.99% -0.09%
==========================================
Files 883 885 +2
Lines 55361 55492 +131
Branches 3791 3795 +4
==========================================
+ Hits 30490 30517 +27
- Misses 24776 24880 +104
Partials 95 95
🚀 New features to boost your workflow:
|
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs. |
const initcodeResult = spawnSync("cargo", ["stylus", "get-initcode"], { | ||
encoding: "utf-8", | ||
}); | ||
const initcode = extractBytecode(initcodeResult.stdout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for error here
}, | ||
sources: {}, | ||
}; | ||
spinner.succeed("ABI cleaned and saved."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prob don't need this line
}): Promise<string> { | ||
const { account, client, chain, compilerMetadata, contractParams, salt } = | ||
options; | ||
|
||
const { deployContract } = await import( | ||
"../../contract/deployment/deploy-with-abi.js" | ||
); | ||
const isStylus = options.compilerMetadata.metadata.language === "rust"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come you're not looking at compiler type here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have that in publish data, but not in compiler metadata (so, I add language as rust and check it later).
PR-Codex overview
This PR introduces support for
Stylus
contracts in the CLI and SDK of thethirdweb
package, enhancing its capabilities for deploying and managing contracts written in theStylus
programming language.Detailed summary
Stylus
contracts in the CLI and SDK.IArbWasm.json
to includeactivateProgram
function.deploy-metadata.ts
to handleStylus
compiler.activateStylusContract
function for contract activation.publish-stylus
,deploy-stylus
, andcreate-stylus
.createStylusProject
for project setup.extraDataWithUri
forStylus
.Stylus
contracts in deployment processes.